Add flag to override GRPC Authority Header #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Aqel <[email protected]>
aliaqel-stripe
force-pushed
the
aliaqel/add-grpc-authority-header
branch
from
bce63f4 to
98dd5f1
Compare
1 task
|
/run-e2e |
|
@JorTurFer Looks like the FOSSA test failed after I updated to main, known failure? |
I'm going to guess a recent import that merged into main broke this test |
You can ignore it. It was broken due to a package issue, but I've fixed in FOSSA. I've retriggered the check and it should pass now 🤞 |
zroubalik
reviewed
Feb 12, 2024
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: aliaqel-stripe <[email protected]>
|
@zroubalik Adopted your comments, let me know how this looks and if we can merge soon so I can consume the CI built Image for this commit |
zroubalik
approved these changes
Feb 12, 2024
|
/run-e2e internal |
ArunYogesh
pushed a commit
to ArunYogesh/keda
that referenced
this pull request
Mar 1, 2024
* add grpc authority head override command-line flag Signed-off-by: Ali Aqel <[email protected]> Signed-off-by: aliaqel-stripe <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Arun Yogesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to the adapter called
metrics-service-grpc-authorityto allow us to set the Authority Header on the GRPC requests so that it can be a host name that is present in the Certificate SAN issued to the keda-operator pod if the GRPC address differs from that.Validated on my KEDA Deployment and verified this header allows us to use TLS with our service mesh addresses + our CA issued certificates.
Checklist
Fixes #5449
Relates to kedacore/keda-docs#1302