-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws secretsmanager additions #6381
Open
mpechner-akasa
wants to merge
14
commits into
kedacore:main
Choose a base branch
from
nrichardson-akasa:aws-secretsmanager-additions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Aws secretsmanager additions #6381
mpechner-akasa
wants to merge
14
commits into
kedacore:main
from
nrichardson-akasa:aws-secretsmanager-additions
+234
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
Signed-off-by: Nick Richardson <[email protected]>
mpechner-akasa
force-pushed
the
aws-secretsmanager-additions
branch
from
November 29, 2024 20:09
a4701ef
to
23175d8
Compare
Signed-off-by: michael pechner <[email protected]>
Signed-off-by: michael pechner <[email protected]>
zroubalik
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks. We should also update docs
mpechner-akasa
added a commit
to mpechner-akasa/keda-docs
that referenced
this pull request
Dec 5, 2024
Doc for issue: kedacore/keda#5940 PR: kedacore/keda#6381 Signed-off-by: michael pechner <[email protected]>
1 task
docs. kedacore/keda-docs#1508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify a secretKey in the awsSecretManager TriggerAuthentication. This will allow parsing of secrets that contain Key/Value pairs (returned in JSON format).
Resubmission of #6031
Provide a description of what has been changed
Checklist
Fixes #5940
Relates to #