Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github webhook broken #646

Open
brianmay opened this issue Nov 27, 2021 · 7 comments
Open

github webhook broken #646

brianmay opened this issue Nov 27, 2021 · 7 comments

Comments

@brianmay
Copy link
Contributor

After following instructions from:

https://keel.sh/docs/#github-webhooks

The github webhook always responds with a 400 status containing:

registry package type was not dockerrepository package name cannot be empty

This is with the latest release of keel.

@brianmay
Copy link
Contributor Author

In the latest image from https://hub.docker.com/r/keelhq/keel/tags using the latest tag, this is still broken. Keel logs the following:

time="2021-11-27T06:13:48Z" level=error msg="provider.kubernetes: got error while checking versioned resource" deployment=penguin-nodes error="Error parsing reference: \"docker.pkg.github.com/brianmay/penguin_nodes/penguin_nodes:sha256:1e0779a4954e0ce29191f9d884a1ff5f8c66228d92aa9013d493a4aacb4e7738\" is not a valid repository/tag, error: invalid reference format" kind=deployment namespace=node-red

And returns a 400 error with:

registry package type was not docker

I am not sure where that reference to docker.pkg.github.com is coming from, I don't see it in the webhook payload, and my deployment is using:

image: ghcr.io/brianmay/penguin_nodes:main

@hnagar-hbk
Copy link

hnagar-hbk commented Jul 20, 2023

Facing the same issue. Using webhookrelay and getting the response bosy - 'registry package type was not docker'

path: chart/keel
repoURL: https://github.com/keel-hq/keel.git
targetRevision: HEAD

@SohamG
Copy link

SohamG commented Jan 26, 2024

Anyone have a fix for this?

@brianmay
Copy link
Contributor Author

brianmay commented Jan 26, 2024

Possibly this was fixed in #741 which was merged into master but not released?

No idea actually, I don't use or trust keel anymore. I don't think it is being actively developed anymore.

(edit: got the bug reference wrong)

@joebowbeer
Copy link
Collaborator

AFAIK, #741 was released

Keel works great for me, but I'm not using any webhooks

Also see #737 and #583

Regarding maintenance, a couple PRs were merged and released last year, including support for initContainers.

@clee231
Copy link

clee231 commented Jan 28, 2024

It looks like #741 was merged in on September 28, 2023(9/28/2023), however the latest release (0.19.1) at the time of this writing was published on August 30, 2023(8/30/2023).
#741 was merged in about a month after the last release, so it likely isn't in the release, unless built from source.

@joebowbeer
Copy link
Collaborator

joebowbeer commented Jan 28, 2024

Update: I reported the missing release in the slack channel

0.19.2 released w/ #741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants