Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined error bug & Add persistent strategy & Various server implementation support #16

Closed
wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2022

fixes #5, fixes #18

Now the library could restore connection unless it is closed by manually called client.close() function.

Alternatively, client.reset() does the same behavior with client.close() function, but it reconnects with server instead of closing it permanently.

example/persistent.js does 50 block header fetch calls in a loop, does client.reset() for every 10% of the calls reached.

Update)

  • Added support for various server implementations
  • Removed deprecated blockchain.address.get_proof method
  • Multiple Node.js version workflows added
  • Parse string to Number for some methods like blockchain.block.header or blockchain.estimatefee since electrs server doesn't support calling method with string

@ghost ghost mentioned this pull request Mar 21, 2022
@ghost
Copy link
Author

ghost commented Mar 22, 2022

Rebased with main branch

@ghost ghost closed this Mar 22, 2022
@ghost ghost reopened this Mar 23, 2022
@ghost
Copy link
Author

ghost commented Mar 23, 2022

Reopened PR with fix of bug that was introduced by PR #9

It haven't changed the leftover of this.subscribe.emit(msg.method, msg.params) which lead to undefined error

cc @nkuba

@ghost ghost changed the title Add persistent strategy Fix undefined error bug & Add persistent strategy Mar 23, 2022
@ghost
Copy link
Author

ghost commented Mar 23, 2022

I think it is now working fine

* Remove deprecated blockchain.address.get_proof method
* Added support for multiple server implementations
* Multiple work flows for Github
@ghost ghost changed the title Fix undefined error bug & Add persistent strategy Fix undefined error bug & Add persistent strategy & Various server implementation support Mar 26, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatibility with variants of ElectrumX Update persistency strategy
0 participants