Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

feat: get entry_points_by_type for ContractClassV1 in RPC calls #790

Closed
apoorvsadana opened this issue Jun 30, 2023 · 16 comments
Closed

feat: get entry_points_by_type for ContractClassV1 in RPC calls #790

apoorvsadana opened this issue Jun 30, 2023 · 16 comments
Assignees
Labels
backlog Ready to be picked enhancement New feature or request good first issue Good for newcomers stale

Comments

@apoorvsadana
Copy link
Collaborator

apoorvsadana commented Jun 30, 2023

Feature Request

Describe the Feature Request

RPC calls get_class_at and get_class use to_rpc_contract_class to convert a blockifier ContractClass to the starknet-rs one. For V1, we need to convert entry_points_by_type from a HashMap<EntryPointType, Vec<EntryPointV1>> (from blockifier) to an instance of EntryPointsByType (from starknet-rs). We will need a way to figure out how to get the function_idx which is required fro EntryPointsByType. A good start for this is to refer to how we went from function_idx to offset and bultins over here.

In case it's impossible to convert back (I am not sure of this as of yet), we might need to store this along with the Sierra program over here #775

@apoorvsadana apoorvsadana added the enhancement New feature or request label Jun 30, 2023
@apoorvsadana apoorvsadana changed the title feat: feat: get entry_points_by_type for ContractClassV1 in RPC calls Jun 30, 2023
@AbdelStark AbdelStark added the good first issue Good for newcomers label Jun 30, 2023
@tchataigner
Copy link

Hey hey ! I'm interested in making my first contribution and I was thinking in handling this one 🙌

I'm currently investigating the method to get function_idx. I'll let you know in a few hours if I could not find a way to get it 👍

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 16, 2023
@KaushikKC
Copy link

Hey, Can you assign me for this issue?
Would like to do it..

@apoorvsadana
Copy link
Collaborator Author

Hey @KaushikKC, awesome! @tdelabro can you assign this to him?

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 22, 2023
@tdelabro
Copy link
Collaborator

@antiyro it seems to be related to the problem you are experiencing with deoxys right now

@Juul-Mc-Goa
Copy link
Contributor

Hi, I'd like to work on this :)
(I'm just starting to work on this project btw, so I might need a bit of help)

@tdelabro
Copy link
Collaborator

One at a time. Focus on #704 for now

@somthn0somthn
Copy link

Is this still open and relevant?

@tdelabro
Copy link
Collaborator

tdelabro commented Nov 9, 2023

@somthn0somthn I think the entry points by type part is doable. You can start with this.
The sierra_program part looks uncertain to me. Don't try for now

I reopened #775 for the sierra program

@somthn0somthn
Copy link

Gotcha. Thanks!

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@mbtariq82
Copy link

Hey, can i take this?

@apoorvsadana
Copy link
Collaborator Author

Sure, assigned @mbtariq82!

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@tdelabro
Copy link
Collaborator

replaced by #1316

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Madara Jan 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog Ready to be picked enhancement New feature or request good first issue Good for newcomers stale
Projects
Status: Done
Development

No branches or pull requests

8 participants