Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size of master password smaller after update #8624

Closed
sycam0r-e opened this issue Oct 23, 2022 · 9 comments · Fixed by #8633
Closed

Font size of master password smaller after update #8624

sycam0r-e opened this issue Oct 23, 2022 · 9 comments · Fixed by #8633

Comments

@sycam0r-e
Copy link

sycam0r-e commented Oct 23, 2022

Overview

I just updated to 2.7.3 pre-release. When unlocking a database, the font size of the database password is now smaller than with 2.7.2 stable. For me, it's just a tad to small. I am aware of #6822 but I did not change my system font size on my Mac in the meantime which leads me to think it might be a change in KeepassXC that led to the different password font size? I have no clue though so happy to learn! :)

Steps to Reproduce

N/A

Expected Behavior

N/A

Actual Behavior

N/A

Context

KeePassXC - Version 2.7.3
Revision: d8483d3

Qt 5.15.6
Debugging mode is disabled.

Operating system: macOS 12.6
CPU architecture: x86_64
Kernel: darwin 21.6.0

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare
  • YubiKey
  • Quick Unlock

Cryptographic libraries:

  • Botan 2.19.2
@sycam0r-e sycam0r-e added the bug label Oct 23, 2022
@droidmonkey
Copy link
Member

We did not change the font size of the password.

@phoerious
Copy link
Member

It's not smaller, but it's a proportional font now, not monospace anymore. I actually don't know why, maybe a side effect of some other change?

droidmonkey added a commit that referenced this issue Oct 24, 2022
* Fix #8627 - don't HTML escape plain text...
* Fix #8624 - ensure use of monospace font when displaying passwords in preview panel
droidmonkey added a commit that referenced this issue Oct 25, 2022
* Fix #8627 - don't HTML escape plain text...
* Fix #8624 - ensure use of monospace font when displaying passwords in preview panel
@phoerious
Copy link
Member

@droidmonkey I don't think you fixed this one. This here is about the master password input field.

@phoerious phoerious reopened this Oct 25, 2022
pull bot pushed a commit to Tiamat-Tech/keepassxc that referenced this issue Oct 25, 2022
* Fix keepassxreboot#8627 - don't HTML escape plain text...
* Fix keepassxreboot#8624 - ensure use of monospace font when displaying passwords in preview panel
pull bot pushed a commit to tigerwill90/keepassxc that referenced this issue Oct 25, 2022
* Fix keepassxreboot#8627 - don't HTML escape plain text...
* Fix keepassxreboot#8624 - ensure use of monospace font when displaying passwords in preview panel
@droidmonkey
Copy link
Member

is now smaller than with 2.7.2 stable

I don't see how that is possible since we did not change anything regarding font size between these versions. I just checked using GammaRay and the font size of the master password input is 9 point on Windows (same as always).

@phoerious
Copy link
Member

phoerious commented Oct 25, 2022

I don't know either, but I noticed it, too. The master password field font is proportional all of a sudden, which at least looks smaller.

@droidmonkey
Copy link
Member

Ahh ok that might be the problem.

@phoerious
Copy link
Member

Seems to be a cross-platform issue. I saw it on macOS, but I also have it on Ubuntu at least.

@vedagel
Copy link

vedagel commented Oct 27, 2022

Can confirm on macOS 12.5.1 (21G83) using KeePassXC - Version 2.7.3

@phoerious
Copy link
Member

Since this seems to be a thing on multiple platforms, I'm closing this one in favour of #8638.

@phoerious phoerious closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2022
droidmonkey added a commit that referenced this issue Oct 29, 2022
* Fix #8627 - don't HTML escape plain text...
* Fix #8624 - ensure use of monospace font when displaying passwords in preview panel
droidmonkey added a commit that referenced this issue Oct 29, 2022
* Fix #8627 - don't HTML escape plain text...
* Fix #8624 - ensure use of monospace font when displaying passwords in preview panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants