Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate addon-manager tests to use Ginkgo v2 #276

Open
tekenstam opened this issue Sep 15, 2023 · 0 comments · Fixed by #319
Open

migrate addon-manager tests to use Ginkgo v2 #276

tekenstam opened this issue Sep 15, 2023 · 0 comments · Fixed by #319
Labels
help wanted Extra attention is needed

Comments

@tekenstam
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

FEATURE REQUEST

What happened:

addon-manager is still using Ginkgo v1, which is EOL. Need to update to Ginkgo v2.

What you expected to happen:

Follow the Ginkgo v2 Migration Guide.

Anything else we need to know?:

Environment:

  • Addon Manager version
  • Kubernetes version :
$ kubectl version -o yaml

Other debugging information (if applicable):

  • Addon status:
$ kubectl describe addon <addon-name>
  • controller logs:
$ kubectl logs <addon-manager-pod>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant