Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Reaper: Refactor #14

Open
eytan-avisror opened this issue Sep 21, 2019 · 2 comments
Open

Node Reaper: Refactor #14

eytan-avisror opened this issue Sep 21, 2019 · 2 comments
Assignees
@eytan-avisror
Labels
enhancement New feature or request node-reaper P1
Milestone
0.2.0

Comments

@eytan-avisror
Copy link
Collaborator

eytan-avisror commented Sep 21, 2019 •
edited
Loading

We need to refactor node reaper, it started as a simple script, but as we add more and more logic, it seems the current structure is becoming a bit flakey.

We should have a make some structural improvements.

  • K8s/AWS clients should be instantiated outside, this will allow to unit tests Run()
  • Better data structures for for reapable/drainable
  • Remove duplicate code
  • A lot of unnecessary if conditions
  • Pass arguments to ReaperContext and validate them in a cleaner way
@eytan-avisror eytan-avisror added this to the 0.2.0 milestone Sep 21, 2019
@eytan-avisror eytan-avisror mentioned this issue Oct 8, 2019
Open
@eytan-avisror eytan-avisror self-assigned this Oct 9, 2019
@aakashchan
Copy link

can i work on this? @eytan-avisror

@eytan-avisror
Copy link
Collaborator Author

@Chan24
Sure, but can you please keep PRs small (vs. very large refactor PRs) so we can review/merge easily?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eytan-avisror eytan-avisror

Labels
enhancement New feature or request node-reaper P1
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@aakashchan @eytan-avisror