Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate taint flag documentation #73

Open
luisdavim opened this issue May 9, 2023 · 0 comments
Open

Inaccurate taint flag documentation #73

luisdavim opened this issue May 9, 2023 · 0 comments

Comments

@luisdavim
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:

Bug report

What happened:

The documentation on --reap-tainted doesn't seem to be correct

What you expected to happen:

The documentation should be accurate

How to reproduce it (as minimally and precisely as possible):

the documentation says:

"marks nodes with a given taint reapable, must be in format of comma separated taints key=value:effect, key:effect or key"

But this flag seems to be using StringArrayVar that means we need to pass the flag multiple times instead of a comma separated string, see: https://pkg.go.dev/github.com/spf13/pflag#StringArrayVar

StringArrayVar defines a string flag with specified name, default value, and usage string. The argument p points to a []string variable in which to store the value of the flag. The value of each argument will not try to be separated by comma. Use a StringSlice for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant