Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display real errors for failed challenges #52

Open
Globulopolis opened this issue Feb 24, 2017 · 3 comments
Open

Display real errors for failed challenges #52

Globulopolis opened this issue Feb 24, 2017 · 3 comments

Comments

@Globulopolis
Copy link

Hi!
I've found this https://github.com/kelunik/acme-client/blob/master/src/Commands/Issue.php#L101-L107 in code. Maybe it's better to throw an real exception message instead of Issuance failed, not all challenges could be solved. ? Because in current implementation foreach is useless.

@kelunik
Copy link
Owner

kelunik commented Apr 15, 2018

The current implementation shows the error messages to the console, why is that useless? Could you clarify?

@Globulopolis
Copy link
Author

I meant an extended error description. Not a predefined value.

@kelunik
Copy link
Owner

kelunik commented Apr 16, 2018

@Globulopolis The foreach about the previous errors should give more information. We could merge them into the exception message, but the information that's given to the end-user will be almost the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants