Fix static analysis errors

kelvinmo · Nov 12, 2024 · e4764ae · e4764ae
1 parent 3801291
commit e4764ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/SimpleJWT/Util/BigNum.php b/src/SimpleJWT/Util/BigNum.php
@@ -68,7 +68,7 @@ public function __construct($str = 0, int $base = 10) {
                 $this->value = $value;
                 return;
             default:
-                if (!is_integer($base) || ($base < 2) || ($base > 36))
+                if (($base < 2) || ($base > 36))
                     throw new \InvalidArgumentException('$base cannot be less than 2 or greater than 36');
 
                 $value = (new BigNum(0))->value;

diff --git a/src/SimpleJWT/Util/CBOR/DataItem.php b/src/SimpleJWT/Util/CBOR/DataItem.php
@@ -123,7 +123,6 @@ class DataItem {
      * @param int $type the type
      * @param mixed $value the native PHP value
      * @param int $tag the tag number (i.e. excluding the class and constructed bit masks)
-     * @throws InvalidArgumentException
      */
     function __construct(int $type, $value, int $tag = null) {
         $this->type = $type;
@@ -233,7 +232,7 @@ static public function simple(int $value): self {
      * @return DataItem
      */
     static public function list(array $value): self {
-        if (!is_array($value) || !self::array_is_list($value)) {
+        if (!self::array_is_list($value)) {
             throw new InvalidArgumentException('Not an array');
         }
         return new self(static::LIST_TYPE, $value);
@@ -246,7 +245,7 @@ static public function list(array $value): self {
      * @return DataItem
      */
     static public function map(array $value): self {
-        if (!is_array($value)|| self::array_is_list($value)) {
+        if (self::array_is_list($value)) {
             throw new InvalidArgumentException('Not an associative array');
         }
         return new self(static::MAP_TYPE, $value);