Remove observer #70
Closed
Remove observer #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ondrejsevcik If you rebase this should pass CI 👍 |
It's not necessary as the value is updated in didUpdateAttrs hook. Should fix #67
|
Rebased |
|
Hi, any estimate when this will be merged? 🙏 thank you |
|
Sorry for the delays everyone, I'm traveling and will get this merged over
the weekend!
On Thu, 25 Oct 2018 at 10:43, Ondrej Sevcik ***@***.***> wrote:
Hi, any estimate when this will be merged? 🙏 thank you
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAiNKjo0dl4YunE4SdLaWVGmx-Escwsks5uoXnBgaJpZM4WuB9r>
.
--
Kenneth Kalmer
@kennethkalmer
http://www.opensourcery.co.za
|
|
Any update on this, it's causing me some issues and I'd rather not have to fork. |
|
Hello @kennethkalmer! Any update on this? I think this is quite straightforward :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary as the value is updated in didUpdateAttrs hook.
Should fix #67