Skip to content
This repository has been archived by the owner on Feb 6, 2025. It is now read-only.

SQLAlchemy API change in 1.4 breaks type hints #1001

Open
branen opened this issue Mar 17, 2021 · 0 comments
Open

SQLAlchemy API change in 1.4 breaks type hints #1001

branen opened this issue Mar 17, 2021 · 0 comments
Assignees

Comments

@branen
Copy link
Collaborator

branen commented Mar 17, 2021

https://docs.sqlalchemy.org/en/14/changelog/migration_14.html#change-result-14-core

This change breaks the type hint for materialize_result_proxy in graphql_compiler.compiler.sqlalchemy_extensions.

Since Result seems to be backwards-compatible with ResultProxy, we can probably support the 1.3 and 1.4 APIs in parallel without much mess, but we should probably update our naming to be consistent with the 1.4 object model (e.g. materialize_result_proxy to materialize_result) and make sure that nothing else broke between 1.3 and 1.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants