Skip to content

Commit

Permalink
fix qualifier datavalue required bug (#18)
Browse files Browse the repository at this point in the history
  • Loading branch information
galtay authored Mar 31, 2019
1 parent 7085882 commit 9e7b29b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
qwikidata Change Log
====================

v0.1.5
======

**Fixed**:

* Bug that required `datavalue` field in Qualifiers even if `snaktype` is `somevalue` or `novalue`.

v0.1.4
======

Expand Down
2 changes: 1 addition & 1 deletion qwikidata/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"""Metadata for this package."""

__package_name__ = "qwikidata"
__version__ = "0.1.4"
__version__ = "0.1.5"
2 changes: 1 addition & 1 deletion qwikidata/claim.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def __init__(self, qualifier_dict: typedefs.QualifierDict) -> None:

def _validate_qualifier_dict(self, qualifier_dict: typedefs.QualifierDict) -> None:
"""Raise excpetions if qualifier_dict is not valid."""
_REQUIRED_KEYS = ["hash", "snaktype", "property", "datavalue", "datatype"]
_REQUIRED_KEYS = ["hash", "snaktype", "property", "datatype"]
for req_key in _REQUIRED_KEYS:
if req_key not in qualifier_dict:
raise ValueError(
Expand Down

0 comments on commit 9e7b29b

Please sign in to comment.