Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘tree/<str:commit_hash>/full’ output is too big #661

Closed
4 tasks done
Tracked by #723
padovan opened this issue Dec 10, 2024 · 3 comments
Closed
4 tasks done
Tracked by #723

‘tree/<str:commit_hash>/full’ output is too big #661

padovan opened this issue Dec 10, 2024 · 3 comments
Assignees

Comments

@padovan
Copy link
Contributor

padovan commented Dec 10, 2024

For a linux-next branch test results, the size of the json file coming out of this API is about 4.6MB, however
only the testHistory bucket has 4.4MB and the bootHistory bucket 0.12MB. The data for the rest of the dict keys is quite small, so we could split this API endpoint into three endpoints:

  • tree/<str:commit_hash>/status: It returns all the data returnedbyfull` except 'testHistory' and 'bootHistory' data
  • tree/<str:commit_hash>/boot-history: It returns the Boot History dict
  • tree/<str:commit_hash>/test-history: It returns the Test History dict

Edit:
Names have been updated to

tree/<commit>/summary
tree/<commit>/builds
tree/<commit>/boots
tree/<commit>/tests

The big tree/<hash>/full output is also causing a long delay in the Web Dashboard. With such a split we can quickly load all the status data and then take the time needed to download the history data and put it on the dashboard.

@padovan
Copy link
Contributor Author

padovan commented Dec 10, 2024

time wget 'https://dashboard.kernelci.org/api/tree/d1486dca38afd08ca279ae94eb3a397f10737824/full?origin=maestro&git_branch=master&git_url=https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git'

real    0m6.700s
user    0m0.077s
sys    0m0.034s

This in the time it takes to get the data back. Of course there are db queries, but the download itself takes a few seconds.

@padovan
Copy link
Contributor Author

padovan commented Dec 18, 2024

Proposed names:

tree/<commit>/summary
tree/<commit>/builds
tree/<commit>/boots
tree/<commit>/tests

Also,

rename “TestHistory” -> “TestList”
rename “BootHistory -> “BootList”

@WilsonNet
Copy link
Collaborator

check if query parameters is viable

@WilsonNet WilsonNet mentioned this issue Jan 6, 2025
30 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in KernelCI Web Dashboard Jan 15, 2025
@WilsonNet WilsonNet mentioned this issue Jan 20, 2025
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants