Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return filters for details pages along filtered data #668

Closed
MarceloRobert opened this issue Dec 11, 2024 · 2 comments
Closed

Return filters for details pages along filtered data #668

MarceloRobert opened this issue Dec 11, 2024 · 2 comments
Assignees

Comments

@MarceloRobert
Copy link
Collaborator

Currently in TreeDetails page the filter modal gets the filters from a separate request to treeDetails without considering the filters (so that all the possible fields appear, not only the fields from the filtered data). That means that TreeDetails makes a request with filters and the modal makes another request without the filters.

In HardwareDetails page the filter modal gets its data from the single request from HardwareDetails, which includes the filters and so the filter fields that appear in the modal are only the fields from the filtered data.

The build/boot/test status and duration filters are hardcoded, and the Tree/Branch filter comes from a separate request, so these aren't affected, only fields such as configs, archs, compilers, hardwares and issues are affected.

Example with current situation:

  • If in TreeDetails there are 10 tests, 5 with config A and 5 with config B, and I filter by config A, what happens is that the page will only show results for config A, but the modal will make another request without the filters so it can get unfiltered data to show configs A and B.
  • If in HardwareDetails there are 10 tests, 5 with issue A and 5 with issue B, if I filter by issue A, what happens is that the page will only show results for issue A, and the modal will get that filtered data for the filter list, showing only issue A but not B.

What should happen is to have a single request returning all the filtered data but also all the possible filters (the modal getting the data from the page request but showing A and B)

@murilx
Copy link
Contributor

murilx commented Dec 24, 2024

Platforms filter are also being affected by the same problem

@MarceloRobert
Copy link
Collaborator Author

Closed by #829 and #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants