Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary query parameters #671

Open
Tracked by #723
, #781
...
murilx opened this issue Dec 11, 2024 · 2 comments
Open
Tracked by #723
, #781
...

Remove unnecessary query parameters #671

murilx opened this issue Dec 11, 2024 · 2 comments
Assignees
@murilx

Comments

@murilx
Copy link
Contributor

murilx commented Dec 11, 2024 •
edited by joaobertacchi
Loading

the URL is to remember user choices, this can be inferred from the sql query response

  • issue
  • commit

Originally posted by @WilsonNet in #666 (comment)
@murilx murilx self-assigned this Dec 11, 2024
@murilx murilx mentioned this issue Dec 11, 2024
Merged
@MarceloRobert MarceloRobert mentioned this issue Jan 10, 2025
Open
30 tasks
@WilsonNet
Copy link
Collaborator

I think we can remove the commit when it is the same as the head commit

@Francisco2002 Francisco2002 mentioned this issue Jan 20, 2025
Open
27 tasks
@murilx murilx moved this from Todo to In Progress in KernelCI Web Dashboard Jan 29, 2025
@murilx murilx moved this from In Progress to Todo in KernelCI Web Dashboard Jan 29, 2025
@murilx
Copy link
Contributor Author

murilx commented Jan 29, 2025

use this feature

https://tanstack.com/router/v1/docs/framework/react/guide/route-masking

or modify this function

https://github.com/TanStack/router/blob/d5d65a2bddab25d76a55186b4bef78d04969e317/packages/router-core/src/searchMiddleware.ts#L24

@WilsonNet WilsonNet mentioned this issue Jan 30, 2025
Open
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murilx murilx

Labels
None yet
Projects
KernelCI Web Dashboard
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilsonNet @murilx