feat(LogSheet): Update UI of log download links #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
commented
Dec 11, 2024
murilx
force-pushed
the
feat/improve-download-log-ui
branch
from
ce8d2a8 to
97ea84c
Compare
WilsonNet
reviewed
Dec 12, 2024
dashboard/src/lib/string.ts
Outdated
Comment on lines
21
to
22
| const protocolRe = /^\w+:\/\//; | ||
| const searchParamsRe = /\?.*$/; |
There was a problem hiding this comment.
Suggested change
| const protocolRe = /^\w+:\/\//; | |
| const searchParamsRe = /\?.*$/; | |
| const protocolRegex = /^\w+:\/\//; | |
| const searchParamsRegex = /\?.*$/; |
WilsonNet
reviewed
Dec 12, 2024
| let replacedUrl = url.replace(protocolRe, ''); | ||
| replacedUrl = replacedUrl.replace(searchParamsRe, ''); | ||
| const splittedUrl = replacedUrl.split('/'); | ||
| const hostname = splittedUrl[0]; |
There was a problem hiding this comment.
Suggested change
| const hostname = splittedUrl[0]; | |
| const hostname = splittedUrl[0] ?? ''; |
typescript strict mode doesn't check array index
There was a problem hiding this comment.
I'm checking for undefined below
WilsonNet
reviewed
Dec 12, 2024
| @@ -202,7 +205,7 @@ export const LogSheet = ({ | |||
| skeletonClassname="h-[3rem]" | |||
| customError={ | |||
| <div className="p-4 text-center"> | |||
| This log url is not supported in the log viewer yet | |||
| You can download your logs here | |||
There was a problem hiding this comment.
I now this wasn't on a message but please put this on a message
There was a problem hiding this comment.
Completely forgot it, you are right
WilsonNet
approved these changes
Dec 12, 2024
murilx
force-pushed
the
feat/improve-download-log-ui
branch
from
97ea84c to
f42d3d6
Compare
Francisco2002
approved these changes
Dec 12, 2024
dashboard/src/lib/string.ts
Outdated
Comment on lines
23
to
24
| let replacedUrl = url.replace(protocolRegex, ''); | ||
| replacedUrl = replacedUrl.replace(searchParamsRegex, ''); |
There was a problem hiding this comment.
Suggested change
| let replacedUrl = url.replace(protocolRegex, ''); | |
| replacedUrl = replacedUrl.replace(searchParamsRegex, ''); | |
| let replacedUrl = url.replace(protocolRegex, '').replace(searchParamsRegex, ''); |
| @@ -202,7 +205,7 @@ export const LogSheet = ({ | |||
| skeletonClassname="h-[3rem]" | |||
| customError={ | |||
| <div className="p-4 text-center"> | |||
| This log url is not supported in the log viewer yet | |||
| <FormattedMessage id="logSheet.logQueryCustomError" /> | |||
There was a problem hiding this comment.
This message is for the log downloader, I don't think we should change it to a download info here; maybe change it above in the place of "Index of"
murilx
force-pushed
the
feat/improve-download-log-ui
branch
2 times, most recently
from
20b3d45 to
38f4d90
Compare
- Added a new function `truncateUrl` used to truncate the URL in the log viewer - Changed the title of the download log table to "Full logs" - Changed the messaged of the QuerySwitcher to "Download your logs here" - Changed the style of the log links, making their font size greater and their color blue with an underline hover effect Closes #655
murilx
force-pushed
the
feat/improve-download-log-ui
branch
from
38f4d90 to
a73b1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
truncateUrlused to truncate the URL in the log viewerCloses #655
Visual Reference
Before
After
