From ae64ccfd3cbee588000722a0e76b0d13788f3ad5 Mon Sep 17 00:00:00 2001 From: Gustavo Padovan Date: Fri, 6 Dec 2024 13:51:22 -0300 Subject: [PATCH 1/2] kci-dev: update description phrase in the cmd line help We want to do more that just submit tests, so let's open up the description. Signed-off-by: Gustavo Padovan --- kcidev/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kcidev/main.py b/kcidev/main.py index 69473e3..b62f666 100755 --- a/kcidev/main.py +++ b/kcidev/main.py @@ -8,7 +8,7 @@ @click.group( - help="Stand alone tool for Linux Kernel developers and maintainers that can test local Linux Kernel changes on a enabled KernelCI server" + help="Stand alone tool for Linux Kernel developers and maintainers to interact with KernelCI" ) @click.version_option("0.1.0", prog_name="kci-dev") @click.option( From f7e8ba7bf5d16db98f1ca88e34da1fc1fdaa3701 Mon Sep 17 00:00:00 2001 From: Gustavo Padovan Date: Fri, 6 Dec 2024 15:15:32 -0300 Subject: [PATCH 2/2] cmds: rename 'results' cmd to 'maestro-results' The results command is accessing the Maestro API directly for fetching results. We want to build an origin agnostic infra, so let's rename this one to 'maestro-results' for clarity. Signed-off-by: Gustavo Padovan --- kcidev/main.py | 6 +++--- kcidev/subcommands/{results.py => maestro_results.py} | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) rename kcidev/subcommands/{results.py => maestro_results.py} (95%) diff --git a/kcidev/main.py b/kcidev/main.py index b62f666..2d264bc 100755 --- a/kcidev/main.py +++ b/kcidev/main.py @@ -4,11 +4,11 @@ import click from kcidev.libs.common import * -from kcidev.subcommands import checkout, commit, patch, results, testretry +from kcidev.subcommands import checkout, commit, patch, maestro_results, testretry @click.group( - help="Stand alone tool for Linux Kernel developers and maintainers to interact with KernelCI" + help="Stand alone tool for Linux Kernel developers and maintainers to interact with KernelCI." ) @click.version_option("0.1.0", prog_name="kci-dev") @click.option( @@ -38,7 +38,7 @@ def run(): cli.add_command(checkout.checkout) cli.add_command(commit.commit) cli.add_command(patch.patch) - cli.add_command(results.results) + cli.add_command(maestro_results.maestro_results) cli.add_command(testretry.testretry) cli() diff --git a/kcidev/subcommands/results.py b/kcidev/subcommands/maestro_results.py similarity index 95% rename from kcidev/subcommands/results.py rename to kcidev/subcommands/maestro_results.py index a6a2da0..97d138b 100644 --- a/kcidev/subcommands/results.py +++ b/kcidev/subcommands/maestro_results.py @@ -72,7 +72,7 @@ def get_nodes(url, limit, offset, filter, field): print_nodes(nodes, field) -@click.command(help="Get results") +@click.command(help="Get results directly from KernelCI's Maestro") @click.option( "--nodeid", required=False, @@ -109,7 +109,7 @@ def get_nodes(url, limit, offset, filter, field): help="Print only particular field(s) from node data", ) @click.pass_context -def results(ctx, nodeid, nodes, limit, offset, filter, field): +def maestro_results(ctx, nodeid, nodes, limit, offset, filter, field): config = ctx.obj.get("CFG") instance = ctx.obj.get("INSTANCE") url = api_connection(config[instance]["api"])