Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming "tests" to "runs" #30

Open
spbnick opened this issue Mar 9, 2021 · 3 comments
Open

Consider renaming "tests" to "runs" #30

spbnick opened this issue Mar 9, 2021 · 3 comments
Assignees

Comments

@spbnick
Copy link
Collaborator

spbnick commented Mar 9, 2021

In the current (v4) and prior schemas we have "test" objects. However, they're not recording information about tests in general, but rather about test executions, or "runs". Having them named "tests" despite this, leaves no good name for the actual data about tests in general. Consider renaming "tests" to "runs" in the schema.

@mrbazzan
Copy link
Contributor

mrbazzan commented Nov 4, 2021

@spbnick Kindly check the PR

mrbazzan added a commit to mrbazzan/kcidb-io that referenced this issue Nov 4, 2021
@spbnick
Copy link
Collaborator Author

spbnick commented Nov 4, 2021

Thanks, @mrbazzan. However, this is actually a big issue. To resolve this properly and completely we would have to:

  • Discuss the change and get an agreement with the KernelCI team.
  • Discuss the change and get an agreement with submitting CI systems.
  • Create a new version of the I/O schema in kcidb-io, initially identical to the latest one, but with empty inherit() function.
  • Rename "tests" to "runs" in the new I/O schema (similarly to what you did to the existing version in the PR).
  • Make the new schema's inherit() function rename "tests" to "runs" in inherited data.
  • Switch the kcidb package to using the new schema version, including:
    • update the version of kcidb-io dependency;
    • update every (real) database driver's schema to use "runs" instead of "tests";
    • update the kcidb.orm module to map between changed database schema and changed ORM representation;
    • update the kcidb.oo module to handle the rename in the ORM representation;
    • update the Jinja2 templates accessing tests, if necessary.
  • Update the Grafana dashboard to use the new database schema
  • Deploy the changes

And I'm probably missing something.

This would also not be a suitable time to do this, as we're trying to make a release and doing all of the above would likely delay us a lot.

So let's postpone this for now :)

@mrbazzan
Copy link
Contributor

mrbazzan commented Nov 4, 2021

So much for quick fix :|
I'll close the PR. Probably pick it up later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants