Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking known/expected test failures and add extra information #2483

Open
laura-nao opened this issue Mar 28, 2024 · 5 comments
Open

Marking known/expected test failures and add extra information #2483

laura-nao opened this issue Mar 28, 2024 · 5 comments
Assignees

Comments

@laura-nao
Copy link
Contributor

laura-nao commented Mar 28, 2024

Hello,

I'd like to discuss potential strategies for marking specific test failures as known or expected. This arises from some dmesg test failures observed on grunt and zork Chromebooks, where the emerg test case is failing due to No irq handler for vector errors being reported in the logs (as expected) - see e.g.: https://lava.collabora.dev/scheduler/job/13063812#results_468058486. This issue is known and harmless on these boards. I'm wondering if it would make sense to have a way to encode this information so that users can easily know about it and act accordingly (e.g. focus on other types of errors or filter out specific test failures if needed).

In the specific case of the dmesg test mentioned, I don't see a sane way to report the exact error log lines from the LAVA test case itself. So I guess this may require users to manually tag failures or provide additional information after they are reported.

I suspect there could be other instances where tests could benefit from manually added debug information (e.g. flakey tests); this issue is to discuss whether any actions should be taken to address these scenarios and explore potential solutions.

cc: @nuclearcat

@musamaanjum
Copy link
Contributor

Adding @nuclearcat and @padovan to the discussion as well.

@musamaanjum
Copy link
Contributor

Assigning to Helen for now. We can change assignee after discussion that how this should be resolved.

@musamaanjum
Copy link
Contributor

@spbnick JFYI This is the ticket in which we are tracking related information.

@musamaanjum
Copy link
Contributor

@helen-fornazier @laura-nao
Example dashboard shows different jobs:

  • Some jobs' log line is "No irq handler for vector". We can ignore them.
  • Some jobs' log line has something else. But it has the error "No irq handler for vector" as well if you look at detailed logs. Example

We want to have a mechanism or support in logspec where we separate all the errors/warnings and compare them with known issues like "No irq handler for vector" in this case. If there are only known issues and no error, mark the test status "ignored" (or "pass").

@musamaanjum
Copy link
Contributor

^ Example
cc: @spbnick @helen-fornazier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants