Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for KnockbackSync #771

Open
lowercasebtw opened this issue Nov 1, 2024 · 1 comment
Open

Support for KnockbackSync #771

lowercasebtw opened this issue Nov 1, 2024 · 1 comment
Labels
incompatibility A plugin that OldCombatMechanics is incompatible with

Comments

@lowercasebtw
Copy link

I already reported this there too (CASELOAD7000/knockback-sync#7) but support with this plugin would be greatly appreciated. Maybe some api setup to allow other plugins to modify the knockback values/code?

@lowercasebtw lowercasebtw added the enhancement A feature or enhancement suggestion for OldCombatMechanics label Nov 1, 2024
@kernitus
Copy link
Owner

kernitus commented Nov 2, 2024

I already reported this there too (CASELOAD7000/knockback-sync#7) but support with this plugin would be greatly appreciated. Maybe some api setup to allow other plugins to modify the knockback values/code?

In what way are they currently not compatible? OCM changes the velocity during the PlayerVelocityEvent on LOWEST priority, meaning it changes it first, and then KnockbackSync can do whatever later modifications are needed since it listens on NORMAL priority - unless it's disregarding the previous velocity and setting a completely new one.

@kernitus kernitus added incompatibility A plugin that OldCombatMechanics is incompatible with and removed enhancement A feature or enhancement suggestion for OldCombatMechanics labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibility A plugin that OldCombatMechanics is incompatible with
Projects
None yet
Development

No branches or pull requests

2 participants