Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per item disable-attack-cooldown. #772

Open
2how opened this issue Nov 25, 2024 · 2 comments
Open

per item disable-attack-cooldown. #772

2how opened this issue Nov 25, 2024 · 2 comments
Labels
enhancement A feature or enhancement suggestion for OldCombatMechanics

Comments

@2how
Copy link

2how commented Nov 25, 2024

disable-attack-cooldown disables the cooldown for all items. The new items introduced in latest versions are designed to have a cooldown like the Maze, if the item does not have it, it becomes really overpowered.

Allow to toggle or disable the cooldown per item type, or have some sort of whitelist of items that will keep the cooldown.

@2how 2how added the enhancement A feature or enhancement suggestion for OldCombatMechanics label Nov 25, 2024
@kernitus
Copy link
Owner

kernitus commented Dec 2, 2024

I understand the sentiment, the problem is that the attack speed is a value in Minecraft that is set for the player, not on an individual item. This is how OCM operates and it would be difficult and performance intensive to do so on a per-item basis.

@2how
Copy link
Author

2how commented Dec 2, 2024

I understand, I thought what OOC does is catch the item data sent to the player and replace the attack speed with the custom attack speed, with this approach you only need to filter the items with custom attack speed and apply the default value to the rest.

A way of balancing the Maze then might be removing the Attack modifier that the maze has based on player Y speed? So it keeps the special mechanics but it deals damage like a normal sword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or enhancement suggestion for OldCombatMechanics
Projects
None yet
Development

No branches or pull requests

2 participants