Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket DB 2.0 #717

Open
kevinhughes27 opened this issue Jul 16, 2017 · 3 comments
Open

Bracket DB 2.0 #717

kevinhughes27 opened this issue Jul 16, 2017 · 3 comments
Assignees
Labels

Comments

@kevinhughes27
Copy link
Owner

kevinhughes27 commented Jul 16, 2017

Bracket DB needs a re-write.

  • the core object the Bracket DB outputs is a division Structure
  • an abstraction for a Stage is required. Stages can be chained together as part of a Structure
  • initial seeding is a special case of a stage input. StageInput might need to be modelled
    • Toornament shows the input for a stage on the left and then the stage itself on the right. This could be integrated in the division page to show all this information
    • division show could have tabs for each stage and pre-select the active stage
  • Stages or stage components should be written as ruby classes (not yml objects)
  • When possible try and have stages receive the input size as an input. e.g be able to generate a single elimination bracket for any size

bracket.pool is a hack that affects how seeding happens. I had to work around this for #730. The game graphs just work if you build them right. The pool partials should take a seeding flag instead of this param.

Related Issues:
#382 #663 #662 #561 #525 #519

@kevinhughes27 kevinhughes27 self-assigned this Jul 16, 2017
@kevinhughes27
Copy link
Owner Author

Some additional notes from a separate thought session:

  • Add a stage abstraction with defined input and output
  • Goal - reduce the amount of code in bracket db for easier maintainability
  • can think of it as writing ruby classes that could be used to generate the current yml files

@kevinhughes27
Copy link
Owner Author

I made a google drawing of the system: https://docs.google.com/drawings/d/1BmwGwyuZgPZ4eCLAwjZXic6GyLoIYEsCTg-ScGJPnnA

@kevinhughes27
Copy link
Owner Author

I was exploring building a bracket DSL as a replacement for the yml files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant