Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peakdetect 1.2 causes dependency conflict #102

Open
antonkulaga opened this issue Jul 4, 2024 · 3 comments
Open

peakdetect 1.2 causes dependency conflict #102

antonkulaga opened this issue Jul 4, 2024 · 3 comments

Comments

@antonkulaga
Copy link

Looks like peakdetect that you use depends on super-outdated scipy, for this reason I get:

  from scipy import fft, ifft
ImportError: cannot import name 'ifft' from 'scipy' (/home/antonkulaga/.local/lib/python3.10/site-packages/scipy/__init__.py)

The proper way to import is:

from scipy.fft import ifft
@kevinjohncutler
Copy link
Owner

@antonkulaga what version of Omnipose are you using? Peakdetect was removed from the dependencies a while ago. I do see that I have it in a conda env file for linux installs, which has not been updated in a while.

@folterj
Copy link

folterj commented Aug 15, 2024

I've got the same issue, pip installed the latest version (1.0.6) of Omnipose today on Windows.
As scipy does not appear to have the version pinned, it installs the latest version of scipy: version 1.14.0.

@folterj
Copy link

folterj commented Aug 19, 2024

So the problem is that peakdetect is ancient, doesn't have scipy version pinned - which would require an equally ancient version of scipy (<1.3.0?).
The change you mention @antonkulaga does not appear to be in the latest release of Omnipose on pypi yet:
e349761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants