Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine type of the classes prop #237

Open
ktaletski opened this issue Jan 17, 2024 · 1 comment
Open

Refine type of the classes prop #237

ktaletski opened this issue Jan 17, 2024 · 1 comment

Comments

@ktaletski
Copy link

🚀 Feature request

Problem description

Looks like type for the classes prop is too strict. Users should either provide classes for all elements or for none.

classes?: {
    root: string;
    trail: string;
    path: string;
    text: string;
    background: string;
};

Suggested solution

I'd suggest to make all entries optional as from the code they seem to actually be that way.

classes?: {
    root?: string;
    trail?: string;
    path?: string;
    text?: string;
    background?: string;
};
@ktaletski
Copy link
Author

I can test it and submit a PR if that works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant