Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Undo Behaviour #16

Open
bbceg opened this issue Dec 17, 2019 · 8 comments
Open

Inconsistent Undo Behaviour #16

bbceg opened this issue Dec 17, 2019 · 8 comments
Labels
upstream Requires a change in Thunderbird

Comments

@bbceg
Copy link

bbceg commented Dec 17, 2019

Version: 2.0.0pre1
Thunderbird: 68.3.0
OS: Windows 10

Steps to reproduce:

  1. Move an email to a folder
  2. Undo the action

Expected result:
Email reappears

Actual result:
Performs the last "non-quickmove" action (e.g. restoring a deleted email)

@kewisch kewisch added bug Something isn't working MailExtension labels Jan 6, 2020
@bbceg
Copy link
Author

bbceg commented Nov 3, 2021

Not sure if this issue can be closed but perhaps worth noting that Undo works fine on v1.10.0 (as I found out to my delight just now!).

@kewisch
Copy link
Owner

kewisch commented Aug 20, 2023

Unfortunately this is broken again due to the rewrite. The new APIs don't have support for the undo/redo manager. See https://bugzilla.mozilla.org/show_bug.cgi?id=1671042 for details. I also don't see an easy way to do this with an internal API.

@kewisch kewisch added upstream Requires a change in Thunderbird and removed MailExtension labels Aug 20, 2023
@bbceg
Copy link
Author

bbceg commented Aug 21, 2023

Still seems to be working for me on v1.10 on Thunderbird 102.14.0, or does this only apply to v2?

@kewisch
Copy link
Owner

kewisch commented Aug 21, 2023

Yes, applies only to v2. I've started using the new WebExtensions/MailExtensions technology here, and those don't support the undo/redo stack at current.

@bbceg
Copy link
Author

bbceg commented Aug 21, 2023

Okay, thanks for confirming and, as ever, your efforts with the add-on. Not sure when it makes to make the switch to v2, 1.10 is working well but presumably has a shelf life.

@kewisch
Copy link
Owner

kewisch commented Aug 21, 2023

Once you upgrade to Thunderbird 115, you'll necessarily be updated to v2. 115 is already out, so just a matter of when automatic updates are pushed out to everyone, or your distro doing the update.

@bbceg
Copy link
Author

bbceg commented Aug 21, 2023

Rats, I was afraid you might say that! Hopefully the undo/redo manager will gain support in the not too distant future.

@kewisch kewisch removed the bug Something isn't working label Oct 13, 2023
@ThomGr
Copy link

ThomGr commented Dec 8, 2023

I understand the difficulty to implement a full undo mechanism, but this is very often causing an issue. If for whatever reason you accidentally move an email to the wrong folder (I have lots of those), and you do not remember a detail of the email, there is no realistic way to find it again (unless you know e.g. the date it was received, the sender etc.). So two suggestions:

  1. can you implement a simple "undo the last action", so the extension itself remembers the last move (and only one, not the stack) and undoes is without attaching to the general undo mechanism. This would of course require a separate shortcut
  2. alternatively, can you display the last move (subject and target folder) so there is a chance to find the last email moved, or implement a "go to" for that last email?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Requires a change in Thunderbird
Projects
None yet
Development

No branches or pull requests

3 participants