Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCRecoTrackerHitPlaneAssociation can / should be removed #301

Closed
tmadlener opened this issue May 8, 2024 · 0 comments · Fixed by #331
Closed

MCRecoTrackerHitPlaneAssociation can / should be removed #301

tmadlener opened this issue May 8, 2024 · 0 comments · Fixed by #331
Labels
enhancement New feature or request

Comments

@tmadlener
Copy link
Contributor

Currently we have two associations for SimTrackerHit to reco level tracker hits:

EDM4hep/edm4hep.yaml

Lines 633 to 649 in a296139

edm4hep::MCRecoTrackerAssociation:
Description: "Association between a TrackerHit and the corresponding SimTrackerHit"
Author: "EDM4hep authors"
Members:
- float weight // weight of this association
OneToOneRelations:
- edm4hep::TrackerHit rec // reference to the reconstructed hit
- edm4hep::SimTrackerHit sim // reference to the simulated hit
edm4hep::MCRecoTrackerHitPlaneAssociation:
Description: "Association between a TrackerHitPlane and the corresponding SimTrackerHit"
Author: "EDM4hep authors"
Members:
- float weight // weight of this association
OneToOneRelations:
- edm4hep::TrackerHitPlane rec // reference to the reconstructed hit
- edm4hep::SimTrackerHit sim // reference to the simulated hit

I am fairly certain these are leftovers from before the introduction of the TrackerHit interface (#252) and the dedicated MCRecoTrackerHitPlaneAssociation has become obsolete by now. I am not entirely sure whether we can simply drop it transparently.

In any case this should also go in before v1.0.

@tmadlener tmadlener added the enhancement New feature or request label May 8, 2024
@tmadlener tmadlener moved this from Todo to Ready for review in EDM4hep v1.0 Jun 26, 2024
@tmadlener tmadlener moved this from Ready for review to Todo in EDM4hep v1.0 Jun 26, 2024
@tmadlener tmadlener moved this from Todo to Ready for review in EDM4hep v1.0 Jun 27, 2024
@github-project-automation github-project-automation bot moved this from Ready for review to Done in EDM4hep v1.0 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant