From b4eb5acbf504c5b21a8543a715530347186d3d6a Mon Sep 17 00:00:00 2001 From: Mateusz Jakub Fila Date: Mon, 26 Aug 2024 10:41:09 +0200 Subject: [PATCH] fix missing ! for schedule_graph --- src/scheduling.jl | 4 ++-- test/demo_workflows.jl | 2 +- test/scheduling.jl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/scheduling.jl b/src/scheduling.jl index 73aa7d8..40dd0ab 100644 --- a/src/scheduling.jl +++ b/src/scheduling.jl @@ -96,7 +96,7 @@ function schedule_algorithm(event::Event, vertex_id::Int, end end -function schedule_graph(event::Event, coefficients::Union{Dagger.Shard, Nothing}) +function schedule_graph!(event::Event, coefficients::Union{Dagger.Shard, Nothing}) terminating_results = Dagger.DTask[] for vertex_id in event.data_flow.algorithm_indices res = schedule_algorithm(event, vertex_id, coefficients) @@ -131,7 +131,7 @@ function run_pipeline(graph::MetaDiGraph; @info dispatch_end_msg(finished_graph_id) end event = Event(data_flow, idx) - terminating_tasks = FrameworkDemo.schedule_graph(event, coefficients) + terminating_tasks = FrameworkDemo.schedule_graph!(event, coefficients) graphs_tasks[idx] = Dagger.@spawn notify_graph_finalization(notifications, idx, terminating_tasks...) diff --git a/test/demo_workflows.jl b/test/demo_workflows.jl index 029f6d7..b67fed7 100644 --- a/test/demo_workflows.jl +++ b/test/demo_workflows.jl @@ -9,7 +9,7 @@ function run_demo(name::String, coefficients::Union{Dagger.Shard, Nothing}) graph = FrameworkDemo.parse_graphml(path) df = FrameworkDemo.DataFlowGraph(graph) event = FrameworkDemo.Event(df) - @test_nowarn wait.(FrameworkDemo.schedule_graph(event, coefficients)) + @test_nowarn wait.(FrameworkDemo.schedule_graph!(event, coefficients)) end end diff --git a/test/scheduling.jl b/test/scheduling.jl index 21a3293..f8e4c9e 100644 --- a/test/scheduling.jl +++ b/test/scheduling.jl @@ -51,7 +51,7 @@ end Dagger.enable_logging!(tasknames = true, taskdeps = true) _ = Dagger.fetch_logs!() # flush logs - tasks = FrameworkDemo.schedule_graph(event, coefficients) + tasks = FrameworkDemo.schedule_graph!(event, coefficients) wait.(tasks) logs = Dagger.fetch_logs!()