Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify CVMFS setup scripts #570

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Unify CVMFS setup scripts #570

wants to merge 3 commits into from

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Mar 13, 2024

BEGINRELEASENOTES

  • Add a unified setup script for CVMFS that uses the deployed script location to determine whether to setup a release or nightlies
    • Reworked argument handling logic based on a while loop
    • Helper functions with longer names that are less likely to clash with other functions

ENDRELEASENOTES

The main goal of this PR is to replace the currently duplicated setup scripts that are deployed on CVMFS by one setup script that sources either nightlies or releases depending on where the script is deployed in the end. This should also work if the script is deployed in other places as long as the installation configuration for spack is the same as we usually use.

This doesn't necessarily simplify the setup script, but at least we only have to fix things in one place in case they are broken.

@tmadlener tmadlener force-pushed the unify-setup-scripts branch from 52839c2 to 9b49c3d Compare March 13, 2024 14:28
@jmcarcell
Copy link
Member

The unification changes a few things, from a quick look this doesn't work with zsh and I'm not sure it will be fine when wrapped in scripts (for example in grid jobs) because of the shifts. The issue is there are a bunch of changes that have been done, there aren't any tests (I started writing some but never got to have them run somewhere in CI) and they are not documented but someone will complain if they are changed. In general I would like to make as few changes in the scripts as possible, the pain is having to copy and paste something twice which is not that bad and the scripts may diverge more in the future (for example listing the packages should be done differently for the nightlies -- currently it only shows the ones that changed -- because they are built differently than the releases) and more changes like that are possible in the future. For the builds it's somehow useful they are split as you can not depend on sw.hsf.org for building the nightlies, but this eventually will change.

Summary: I would like to keep them as they are and only fix what's broken and add features if there is a demand and they are useful

@tmadlener
Copy link
Contributor Author

Yeah, I see the point. I am not the biggest fan of the duplication, especially for the utility functionality like detecting the os, etc... Should we try to at least to unify that a bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants