From 14c7e4fa5affa648f1e31559fb3452187f969d75 Mon Sep 17 00:00:00 2001 From: Jesse Vincent Date: Mon, 13 May 2024 13:47:32 -0700 Subject: [PATCH] Fix udev rule syntax in HelpConnection - Corrected attribute syntax from `ATTR` to `ATTRS` for `idVendor` and `idProduct` in udev rules generation within `HelpConnection.js`. This change ensures proper device identification and access on Linux systems. "The singular form of udev criteria (KERNEL, SUBSYSTEM, DRIVER, ATTR) only match the device being added, whereas the plural forms (including ATTRS) match the device being added or any of its parent devices." per https://unix.stackexchange.com/questions/424727/difference-between-attrs-and-attr-in-udev-rules --- src/renderer/screens/Help/Connection.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderer/screens/Help/Connection.js b/src/renderer/screens/Help/Connection.js index dbccefae9..03b759614 100644 --- a/src/renderer/screens/Help/Connection.js +++ b/src/renderer/screens/Help/Connection.js @@ -20,9 +20,9 @@ const HelpConnection = () => { // First build up a list of all known devices: const rules = supportedDeviceVIDPIDs().map((device) => { - return `SUBSYSTEM=="usb", ATTR{idVendor}=="${device.usbVendorId + return `SUBSYSTEM=="usb", ATTRS{idVendor}=="${device.usbVendorId .toString(16) - .padStart(4, "0")}", ATTR{idProduct}=="${device.usbProductId.toString(16).padStart(4, "0")}", SYMLINK+="${ + .padStart(4, "0")}", ATTRS{idProduct}=="${device.usbProductId.toString(16).padStart(4, "0")}", SYMLINK+="${ device.productName }", ENV{ID_MM_DEVICE_IGNORE}:="1", ENV{ID_MM_CANDIDATE}:="0", TAG+="uaccess", TAG+="seat"\n`; });