Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xon/xoff flow control may be stalling out waiting for more input. #1367

Closed
obra opened this issue Dec 12, 2023 · 1 comment · Fixed by #1369 or #1370
Closed

xon/xoff flow control may be stalling out waiting for more input. #1367

obra opened this issue Dec 12, 2023 · 1 comment · Fixed by #1369 or #1370
Labels
bug Something isn't working

Comments

@obra
Copy link
Member

obra commented Dec 12, 2023

@tlyu says: xon/xoff from Focus are acting weird in ways i haven’t quite characterized yet. sometimes Focus will send an xoff but not send an xon for a long time, sometimes only after it gets more input!

image
We almost certainly want to manage flow control on both sides of those reads.
@obra obra added the bug Something isn't working label Dec 12, 2023
This was linked to pull requests Dec 14, 2023
Reduce the chances of xon/xoff causing comms to wedge #1369
Merged
Remove xon/xoff flow control, now that we have more proper usb-level flow control #1370
Merged
@tlyu
Copy link
Collaborator

tlyu commented Dec 14, 2023

Fixed by #1369 and #1370.

@tlyu tlyu closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@obra @tlyu