Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove scripts from composer.json #493

Open
mcdurdin opened this issue Oct 31, 2024 · 2 comments
Open

chore: remove scripts from composer.json #493

mcdurdin opened this issue Oct 31, 2024 · 2 comments
Labels
Milestone

Comments

@mcdurdin
Copy link
Member

Ah, I added the one in composer.json in #389 for feature parity with help.keyman.com

Hmm, so we should probably remove from all then. Let's keep composer.json minimal, remove all scripts, seeing as we do them in ci.yml now?

I see we never call composer run test either, which means we should probably add vendor/bin/phpunit --testdox to ci.yml and/or Dockerfile?

How do we run lint and phpunit tests locally?

Originally posted by @mcdurdin in #492 (comment)

  1. Remove the scripts from composer.json
  2. Make it possible to lint and phpunit test from local dev machine
  3. Consolidate ci.yml and build.sh test calls (ci.yml should be able to call build.sh?)

This should also be done on help.keyman.com, elsewhere as well?

@darcywong00
Copy link
Contributor

How do we run lint and phpunit tests locally?

I thought one of the intents of putting everything into Docker is that the dev environment doesn't need to install anything else (Composer, PHP, phpunit, etc)

@mcdurdin
Copy link
Member Author

mcdurdin commented Nov 5, 2024

How do we run lint and phpunit tests locally?

I thought one of the intents of putting everything into Docker is that the dev environment doesn't need to install anything else (Composer, PHP, phpunit, etc)

Yeah, but we still need to be able to trigger them, even if they run in the container, right? How do we do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants