From 5ec2ce78634d3e5b9ff684741f184eecaf0a0afe Mon Sep 17 00:00:00 2001 From: Marc Durdin Date: Thu, 5 Dec 2024 05:35:27 +0700 Subject: [PATCH] chore: address review comments --- core/docs/api/changes.md | 2 +- core/docs/api/keyboards.md | 4 ++-- core/tests/unit/km_core_keyboard_api.tests.cpp | 12 ------------ 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/core/docs/api/changes.md b/core/docs/api/changes.md index ab8a2e287a1..e5736494abc 100644 --- a/core/docs/api/changes.md +++ b/core/docs/api/changes.md @@ -43,7 +43,7 @@ title: Changes - Keyman Core API [km_core_keyboard_attrs]: keyboards#km_core_keyboard_attrs "km_core_keyboard_attrs struct" [km_core_keyboard_key]: keyboards#km_core_keyboard_key "km_core_keyboard_key struct" [km_core_keyboard_imx]: keyboards#km_core_keyboard_imx "km_core_keyboard_imx struct" -[km_core_keyboard_load]: keyboards#km_core_keyboard_load "km_core_keyboard_load function" +[km_core_keyboard_load_from_blob]: keyboards#km_core_keyboard_load_from_blob "km_core_keyboard_load_from_blob function" [km_core_keyboard_dispose]: keyboards#km_core_keyboard_dispose "km_core_keyboard_dispose function" [km_core_keyboard_get_attrs]: keyboards#km_core_keyboard_get_attrs "km_core_keyboard_get_attrs function" [km_core_keyboard_get_key_list]: keyboards#km_core_keyboard_get_key_list "km_core_keyboard_get_key_list function" diff --git a/core/docs/api/keyboards.md b/core/docs/api/keyboards.md index 6f02b428898..3439e20722b 100644 --- a/core/docs/api/keyboards.md +++ b/core/docs/api/keyboards.md @@ -106,8 +106,8 @@ typedef struct { ## Description -Parse and load keyboard from the supplied blob and size and a pointer to the -loaded keyboard into the out paramter. +Parse and load a keyboard from the supplied blob and return a pointer to the +loaded keyboard in the out parameter. ## Specification diff --git a/core/tests/unit/km_core_keyboard_api.tests.cpp b/core/tests/unit/km_core_keyboard_api.tests.cpp index fb9ea32818d..2898f9e7cd7 100644 --- a/core/tests/unit/km_core_keyboard_api.tests.cpp +++ b/core/tests/unit/km_core_keyboard_api.tests.cpp @@ -10,18 +10,6 @@ km::core::path test_dir; -// #if defined(__GNUC__) || defined(__clang__) -// #define PRAGMA(X) _Pragma(#X) -// #define DISABLE_WARNING_PUSH PRAGMA(GCC diagnostic push) -// #define DISABLE_WARNING_POP PRAGMA(GCC diagnostic pop) -// #define DISABLE_WARNING(W) PRAGMA(GCC diagnostic ignored #W) -// #define DISABLE_WARNING_DEPRECATED_DECLARATIONS DISABLE_WARNING(-Wdeprecated-declarations) -// #else -// #define DISABLE_WARNING_PUSH -// #define DISABLE_WARNING_POP -// #define DISABLE_WARNING_DEPRECATED_DECLARATIONS -// #endif - class KmCoreKeyboardApiTests : public testing::Test { protected: km_core_keyboard* keyboard = nullptr;