Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(common): a trailing space should be removed when a punctuation is added #10834

Closed
2 of 8 tasks
MakaraSok opened this issue Feb 26, 2024 · 2 comments
Closed
2 of 8 tasks

Comments

@MakaraSok
Copy link
Collaborator

Describe the bug

A space got added when a word is picked from the suggestion banner. That is not the issue.

What troubles me is that when a punctuation is used the space does not get away.

Try and type "Ple" and then pick "Please" from the banner. Now press . to see the issue as shown below.
image

Reproduce the bug

No response

Expected behavior

It may be helpful to remove the space when a punctuation is pressed/added. The space can be both visible and invisible and they have to be removed.

Related issues

No response

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form

Keyman version

17.0.275-beta

Operating system

Android 10

Device

Samsung Galaxy S9+

Target application

Keyman

Browser

No response

Keyboard name

EuroLatin (SIL)

Keyboard version

2.0.4

Language name

English

Additional context

No response

@MakaraSok
Copy link
Collaborator Author

#7163

@mcdurdin
Copy link
Member

Duplicate of #7163

@mcdurdin mcdurdin marked this as a duplicate of #7163 Feb 26, 2024
@mcdurdin mcdurdin closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S2 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants