Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Move normalize and restore line break functionality to Keyman Core. #10954

Open
rc-swag opened this issue Mar 6, 2024 · 1 comment
Open

feat(core): Move normalize and restore line break functionality to Keyman Core. #10954

rc-swag opened this issue Mar 6, 2024 · 1 comment
Assignees
@ermshiperete
Labels
core/ Keyman Core feat
Milestone
19.0

Comments

@rc-swag
Copy link
Contributor

rc-swag commented Mar 6, 2024

PR #10697 added functionality to the Keyman for Windows engine to detect the type of line feed being used CRLF, LF, or just CR and normalized it to just LF (u+000A). It then restored the line break used when outputting to the application. This functionality go could be used in the Core and then all the platforms would not need to handle it. It could then be removed from the Windows engine also.
@rc-swag rc-swag added this to the 18.0 milestone Mar 6, 2024
@keymanapp-test-bot keymanapp-test-bot bot added core/ Keyman Core feat labels Mar 6, 2024
@rc-swag rc-swag mentioned this issue Mar 6, 2024
Closed
@mcdurdin mcdurdin modified the milestones: 18.0, A18S6 Apr 29, 2024
@darcywong00 darcywong00 modified the milestones: A18S6, A18S7 Jul 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@mcdurdin mcdurdin added this to Keyman Aug 19, 2024
@ermshiperete ermshiperete moved this to Todo in Keyman Aug 19, 2024
@ermshiperete ermshiperete modified the milestones: A18S9, A18S10 Aug 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S10, A18S11 Sep 14, 2024
@darcywong00 darcywong00 modified the milestones: A18S11, A18S12 Sep 28, 2024
@mcdurdin mcdurdin modified the milestones: A18S12, 19.0 Oct 9, 2024
@mcdurdin
Copy link
Member

mcdurdin commented Oct 9, 2024

Moving to 19.0 because web-core is higher priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ermshiperete ermshiperete

Labels
core/ Keyman Core feat
Projects
Keyman
Status: Todo
Milestone
19.0
Development

No branches or pull requests
4 participants
@ermshiperete @mcdurdin @darcywong00 @rc-swag