Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): quality pass for locked-flick resetting may be needed #11139

Open
jahorton opened this issue Apr 2, 2024 · 4 comments
Open

chore(web): quality pass for locked-flick resetting may be needed #11139

jahorton opened this issue Apr 2, 2024 · 4 comments
Assignees
Milestone

Comments

@jahorton
Copy link
Contributor

jahorton commented Apr 2, 2024

Test Results

(From #11129)

  • TEST_GESTURE_REGRESSIONS (FAILED): Tested with the attached PR build (Keyman 17.0.296-beta-test-11129) on an Android (13) Mobile device and here is my observation: 1. Tested the baseline tests on the "Test unminified KeymanWeb" test page on the Chrome browser and noticed that some tests like Test_Numeric_From_Shift, Test_Modipress_Multitap_Flick_Preview and Test_Flick_during_Modipress are failed due to a lack of motion in animation while dragging the specified key by up-and-right motion or sometimes with straight up or down motion.

I have attached a video file (test_flick_during_modipress) represents there is a lack of motion in the animation and it does not show the expected output Úq on the text input screen.

modipressmultitap.mp4

Originally posted by @bharanidharanj in #11129 (comment)

@jahorton
Copy link
Contributor Author

jahorton commented Apr 2, 2024

It's quite possible that the best way forward, from a user-testing perspective, is to develop a different testing keyboard that specifies 90-degree offset flicks, rather than 45-degree neighboring ones. Flick-locking should operate more intuitively in such cases.

@mcdurdin
Copy link
Member

@jahorton I am not sure what to do with this -- is there specific work that you see that we should do apart from changing the keyboard?

I have not yet assigned this to you or this sprint; is this work that we need to complete before release?

@jahorton
Copy link
Contributor Author

@jahorton I am not sure what to do with this -- is there specific work that you see that we should do apart from changing the keyboard?

I have not yet assigned this to you or this sprint; is this work that we need to complete before release?

We can probably get by without doing this before release; I think it's more a "user testing stability" issue than anything else.

@mcdurdin mcdurdin added this to the 18.0 milestone Apr 18, 2024
@jahorton
Copy link
Contributor Author

Also... I think the prospective sil_ipa variant I put together might work well as a test keyboard for this. Its flick pattern matches the pattern I was thinking of, now that I'm thinking about it.

@mcdurdin mcdurdin modified the milestones: 18.0, A18S20 Apr 29, 2024
@mcdurdin mcdurdin modified the milestones: A18S20, 19.0 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants