Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(web): modipress held from multitapping releases early if first key from new layer is pressed too early #11187

Closed
jahorton opened this issue Apr 8, 2024 · 0 comments · Fixed by #11189
Assignees
Milestone

Comments

@jahorton
Copy link
Contributor

jahorton commented Apr 8, 2024

Does reproduce:

  1. With sil_euro_latin 3.0+...
  2. Triple tap the numeric key, holding the final tap instead of releasing it.
  3. Quickly tap any non-frame key.

Result: the key produces its text and you are immediately returned to the default layer.

Does not reproduce:

  1. With sil_euro_latin 3.0+...
  2. Triple tap the numeric key, holding the final tap instead of releasing it.
  3. Wait ~0.5 seconds.
  4. Tap any non-frame key.

You will remain on the same layer until the held, layer-swapping finger is lifted.

Does not reproduce:

  1. With sil_euro_latin 3.0+...
  2. Press and hold the numeric key.
  3. Quickly tap any key from the second or third row aside from the key in s position.

You will remain on the numeric layer.

Thus, this only triggers for modipresses reached by multitaps, and only if the first key that would normally trigger a layer swap happens before the multitap timer completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants