Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(developer): Renaming a keyboard folder and opening .kpj file crashes #11194

Closed
darcywong00 opened this issue Apr 8, 2024 · 4 comments · Fixed by #11252
Closed

bug(developer): Renaming a keyboard folder and opening .kpj file crashes #11194

darcywong00 opened this issue Apr 8, 2024 · 4 comments · Fixed by #11252

Comments

@darcywong00
Copy link
Contributor

Reported on Slack by @DavidLRowe

If I have a keyboard in a folder (inddv), then rename the folder (inddv test), then double-click on the inddv.kpj file, Developer 17.0.295-beta crashes.
same with 17.0.303-beta

Details for error report for Keyman app:
Application Identifier: tike-17.0.303-beta
Error Identifier: B13071DD61AF447F17903A6D3C381C0D

@darcywong00
Copy link
Contributor Author

Assigning to Marc when he's back in B17S6

@DavidLRowe
Copy link
Contributor

For reference, the 'inddv' keyboard in question was from keymanapp/keyboards#2669

Copy link

sentry-io bot commented Apr 8, 2024

Sentry Issue: KEYMAN-DEVELOPER-1K1

@mcdurdin
Copy link
Member

OS Version: Windows 10.0.22631 (3296)
Report Version: 104


Application Specific Information:
Exception EAccessViolation in module tike.exe at 00A94BD2.
Access violation at address 00E94BD2 in module 'tike.exe'. Read of address 00000007.


Thread 0
0   tike.exe                        0xe94bd2            UfrmMain.TfrmKeymanDeveloper.OpenFile (UfrmMain.pas:1303)
1   tike.exe                        0xe934e1            UfrmMain.TfrmKeymanDeveloper.WMUserFormShown (UfrmMain.pas:815)
2   tike.exe                        0x575c58            Vcl.Controls.TControl.WndProc (Vcl.Controls.pas:7420)
3   tike.exe                        0x57a70f            Vcl.Controls.TWinControl.WndProc (Vcl.Controls.pas:10278)
4   tike.exe                        0x67b55d            Vcl.Forms.TCustomForm.WndProc (Vcl.Forms.pas:4652)
5   tike.exe                        0xe937a7            UfrmMain.TfrmKeymanDeveloper.WndProc (UfrmMain.pas:867)
6   tike.exe                        0x7c3499            JvDockControlForm.TJvDockBaseControl.WindowProc (JvDockControlForm.pas:2483)
7   tike.exe                        0x48bdc5            System.Classes.StdWndProc (System.Classes.pas:17929)
8   USER32.dll                      0x77552f62          _InternalCallWinProc
9   USER32.dll                      0x77543d45          UserCallWinProcCheckWow
10  USER32.dll                      0x77542604          DispatchMessageWorker
11  USER32.dll                      0x7754214f          DispatchMessageW
12  tike.exe                        0x684f4b            Vcl.Forms.TApplication.ProcessMessage (Vcl.Forms.pas:10747)
13  tike.exe                        0x684f8e            Vcl.Forms.TApplication.HandleMessage (Vcl.Forms.pas:10777)
14  tike.exe                        0x6852c1            Vcl.Forms.TApplication.Run (Vcl.Forms.pas:10915)

mcdurdin added a commit that referenced this issue Apr 18, 2024
…erence on startup

Fixes #11194.

If the last-used project file no longer exists (e.g. has been renamed),
then Keyman Developer would crash as it did not test that the file had
been loaded successfully before attempting to reference it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants