Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): unexpected KM_CORE_IT_INVALIDATE_CONTEXT causes EAssertionFailed in debugger #11486

Closed
sentry-io bot opened this issue May 21, 2024 · 3 comments · Fixed by #11488
Closed

bug(developer): unexpected KM_CORE_IT_INVALIDATE_CONTEXT causes EAssertionFailed in debugger #11486

sentry-io bot opened this issue May 21, 2024 · 3 comments · Fixed by #11488
Assignees
@mcdurdin
Labels
bug developer/
Milestone
A18S2

Comments

@sentry-io
Copy link

sentry-io bot commented May 21, 2024

Sentry Issue: KEYMAN-DEVELOPER-1Y4

EAssertionFailed: Exception EAssertionFailed in module tike.exe at 00942F8B.
Assertion failure (C:\BuildAgent\work\82cac59564031c74\keyman\developer\src\tike\debug\Keyman.System.Debug.DebugEvent.pas, line 372).

  File "Keyman.System.Debug.DebugEvent.pas", line 373, in Keyman.System.Debug.DebugEvent.TDebugEventList.AddStateItems
    end;
  File "System.pas", line 24855, in System.@Assert
  File "Keyman.System.Debug.DebugEvent.pas", line 372, in Keyman.System.Debug.DebugEvent.TDebugEventList.AddStateItems
    Assert(action._type = KM_CORE_IT_END);
  File "UfrmDebug.pas", line 473, in UfrmDebug.TfrmDebug.ProcessKeyEvent
    FEvents.AddStateItems(FDebugCore.State, vkey, modifier, debugkeyboard);
  File "UfrmDebug.pas", line 342, in UfrmDebug.TfrmDebug.HandleMemoKeydown
    Exit(ProcessKeyEvent(Message));
...
(11 additional frame(s) were not displayed)
@mcdurdin mcdurdin added this to the A18S2 milestone May 21, 2024
@mcdurdin
Copy link
Member

Emerging from #11172

@mcdurdin mcdurdin mentioned this issue May 21, 2024
Merged
mcdurdin added a commit that referenced this issue May 21, 2024
@mcdurdin
fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger
c52d32c 
The output from Keyman Core changed in #11172 to emit a
`KM_CORE_IT_INVALIDATE_CONTEXT` action when a frame key is pressed, but
the debugger was not catering for this scenario, causing an assertion
failure.

Fixes: #11486
Fixes: KEYMAN-DEVELOPER-1Y4
@mcdurdin mcdurdin mentioned this issue May 21, 2024
Merged
mcdurdin added a commit that referenced this issue May 21, 2024
@mcdurdin
fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger
1969319 
The output from Keyman Core changed in #11172 to emit a
`KM_CORE_IT_INVALIDATE_CONTEXT` action when a frame key is pressed, but
the debugger was not catering for this scenario, causing an assertion
failure.

Fixes: #11486
Fixes: KEYMAN-DEVELOPER-1Y4
This was referenced May 21, 2024
Merged
Merged
@srl295
Copy link
Member

srl295 commented May 21, 2024

🙀

@mcdurdin
Copy link
Member

Ref: https://community.software.sil.org/t/keyman-developer-17-upgrade-issues/8757/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug developer/
Projects
None yet
Milestone
A18S2
Development

Successfully merging a pull request may close this issue.

fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger keymanapp/keyman
2 participants
@srl295 @mcdurdin