Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Deprecate km_core_keyboard_load #12497

Closed
4 of 5 tasks
ermshiperete opened this issue Oct 2, 2024 · 4 comments · Fixed by #12769
Closed
4 of 5 tasks

chore(core): Deprecate km_core_keyboard_load #12497

ermshiperete opened this issue Oct 2, 2024 · 4 comments · Fixed by #12769
Assignees
@mcdurdin
Labels
chore core/ Keyman Core
Milestone
A18S16

Comments

@ermshiperete
Copy link
Contributor

ermshiperete commented Oct 2, 2024 •
edited by mcdurdin
Loading

#12459 added the new core API method km_core_keyboard_load_from_blob. Once we changed the engines to use the new method we should add the deprecated flag to km_core_keyboard_load.
@keymanapp-test-bot keymanapp-test-bot bot added chore core/ Keyman Core labels Oct 2, 2024
@mcdurdin
Copy link
Member

mcdurdin commented Oct 7, 2024

Added WASM TODO item

@ermshiperete ermshiperete added this to the A18S25 milestone Nov 4, 2024
@ermshiperete
Copy link
Contributor Author

Needs to happen after the Linux/Mac/Windows subtasks are done.

@ermshiperete ermshiperete modified the milestones: A18S25, 19.0 Nov 25, 2024
@mcdurdin
Copy link
Member

Note: once mac work is done (#12499), we can remove the filesystem code entirely from Core, rather than #ifdef or deprecation of the API. This will be much cleaner!

@mcdurdin mcdurdin moved this to In Progress in Keyman Nov 27, 2024
@mcdurdin mcdurdin modified the milestones: 19.0, 18.0, A18S16 Nov 27, 2024
@mcdurdin
Copy link
Member

As we are so close to getting this finished, brought it back to milestone 18.0.

@mcdurdin mcdurdin self-assigned this Nov 27, 2024
@mcdurdin mcdurdin moved this from In Progress to Blocked in Keyman Nov 28, 2024
@mcdurdin mcdurdin moved this from Blocked to In Progress in Keyman Dec 3, 2024
@mcdurdin mcdurdin mentioned this issue Dec 4, 2024
Merged
@mcdurdin mcdurdin moved this from In Progress to Waiting for user in Keyman Dec 4, 2024
@ermshiperete ermshiperete mentioned this issue Dec 4, 2024
Open
@github-project-automation github-project-automation bot moved this from Waiting for user to Done in Keyman Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
chore core/ Keyman Core
Projects
Keyman
Archived in project
Milestone
A18S16
Development

Successfully merging a pull request may close this issue.

chore(core): remove km_core_keyboard_load API keymanapp/keyman
2 participants
@ermshiperete @mcdurdin