Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): kmc-generate lists all platforms for lexical models #12592

Closed
mcdurdin opened this issue Oct 30, 2024 · 1 comment · Fixed by #12803
Closed

bug(developer): kmc-generate lists all platforms for lexical models #12592

mcdurdin opened this issue Oct 30, 2024 · 1 comment · Fixed by #12803
Assignees
@mcdurdin
Labels
bug developer/
Milestone
A18S17

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Oct 30, 2024 •
edited
Loading

lexical model README.md test fixture shows:

Supported Platforms
-------------------
 * Windows
 * macOS
 * Linux
 * Web
 * iPhone
 * iPad
 * Android phone
 * Android tablet
 * Mobile devices
 * Desktop devices
 * Tablet devices

Maybe this is carry-over from Developer template projects.
I thought lexical-models are only supported on mobile platforms.

Originally posted by @darcywong00 in #11014 (comment)
@mcdurdin mcdurdin mentioned this issue Oct 30, 2024
Merged
@mcdurdin mcdurdin added this to the A18S19 milestone Oct 31, 2024
@mcdurdin mcdurdin self-assigned this Oct 31, 2024
@mcdurdin
Copy link
Member Author

Solution is probably to remove 'supported platforms' altogether since lexical models never have any platform-specific code in them by design. (The limitation on platform is in the predictive text engine itself at this point)

mcdurdin added a commit that referenced this issue Dec 8, 2024
@mcdurdin
fix(developer): remove platforms from kmc-generate LM readme
09d14da 
Lexical models are not specific to a platform, so the readme should not
list supported platforms.

Fixes: #12592
@mcdurdin mcdurdin mentioned this issue Dec 8, 2024
Merged
@mcdurdin mcdurdin modified the milestones: A18S19, A18S17 Dec 8, 2024
@github-project-automation github-project-automation bot moved this to Done in Keyman Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug developer/
Projects
Keyman
Archived in project
Milestone
A18S17
Development

Successfully merging a pull request may close this issue.

fix(developer): remove platforms from kmc-generate LM readme keymanapp/keyman
1 participant
@mcdurdin