From 3cf1f346b5cb3f3b432bf6482415bfeabe39dbc0 Mon Sep 17 00:00:00 2001
From: rui-mo <rui.mo@intel.com>
Date: Fri, 19 Jan 2024 11:32:37 -0800
Subject: [PATCH] Remove deprecated configs `kCastToIntByTruncate` and
 `kCastStringToDateIsIso8601` (#8352)

Summary:
After https://github.com/facebookincubator/velox/pull/7377, kCastToIntByTruncate and kCastStringToDateIsIso8601 are no longer in use.

Pull Request resolved: https://github.com/facebookincubator/velox/pull/8352

Reviewed By: mbasmanova

Differential Revision: D52737612

Pulled By: kagamiori

fbshipit-source-id: c82d55a592b85a16bce5c29b20d22f7a19c6c9a3
---
 velox/core/QueryConfig.h | 29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/velox/core/QueryConfig.h b/velox/core/QueryConfig.h
index 88eea66ac925..25a18e61c678 100644
--- a/velox/core/QueryConfig.h
+++ b/velox/core/QueryConfig.h
@@ -101,25 +101,6 @@ class QueryConfig {
   static constexpr const char* kCastMatchStructByName =
       "cast_match_struct_by_name";
 
-  /// If set, cast from float/double/decimal/string to integer truncates the
-  /// decimal part, otherwise rounds.
-  static constexpr const char* kCastToIntByTruncate = "cast_to_int_by_truncate";
-
-  /// If set, cast from string to date allows only ISO 8601 formatted strings:
-  /// [+-](YYYY-MM-DD). Otherwise, allows all patterns supported by Spark:
-  /// `[+-]yyyy*`
-  /// `[+-]yyyy*-[m]m`
-  /// `[+-]yyyy*-[m]m-[d]d`
-  /// `[+-]yyyy*-[m]m-[d]d *`
-  /// `[+-]yyyy*-[m]m-[d]dT*`
-  /// The asterisk `*` in `yyyy*` stands for any numbers.
-  /// For the last two patterns, the trailing `*` can represent none or any
-  /// sequence of characters, e.g:
-  ///   "1970-01-01 123"
-  ///   "1970-01-01 (BC)"
-  static constexpr const char* kCastStringToDateIsIso8601 =
-      "cast_string_to_date_is_iso_8601";
-
   /// Used for backpressure to block local exchange producers when the local
   /// exchange buffer reaches or exceeds this size.
   static constexpr const char* kMaxLocalExchangeBufferSize =
@@ -510,16 +491,6 @@ class QueryConfig {
     return get<bool>(kCastMatchStructByName, false);
   }
 
-  // TODO: to be removed.
-  bool isCastToIntByTruncate() const {
-    return get<bool>(kCastToIntByTruncate, false);
-  }
-
-  // TODO: to be removed.
-  bool isIso8601() const {
-    return get<bool>(kCastStringToDateIsIso8601, true);
-  }
-
   bool codegenEnabled() const {
     return get<bool>(kCodegenEnabled, false);
   }