From ad266a414b23c18d289fa7bbf0aee3f63a5961eb Mon Sep 17 00:00:00 2001
From: Krishna Pai <kpai@fb.com>
Date: Tue, 9 Apr 2024 17:24:48 -0700
Subject: [PATCH] Making changes to sum aggregate.

---
 .github/workflows/scheduled.yml                             | 4 ++++
 velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp | 1 +
 velox/functions/prestosql/aggregates/SumAggregate.cpp       | 2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/scheduled.yml b/.github/workflows/scheduled.yml
index 2e5b23bfc9ab5..2fb261ce671bb 100644
--- a/.github/workflows/scheduled.yml
+++ b/.github/workflows/scheduled.yml
@@ -708,7 +708,11 @@ jobs:
           rm -rfv /tmp/aggregate_fuzzer_repro/*
           chmod -R 777 /tmp/aggregate_fuzzer_repro
           chmod +x velox_aggregation_fuzzer_test
+          echo "signatures folder"
+          ls /tmp/signatures/
+          echo "Biased functions:"
           cat /tmp/signatures/presto_aggregate_bias_functions
+          echo "Running Fuzzer"
           ./velox_aggregation_fuzzer_test \
                 --seed ${RANDOM} \
                 --duration_sec $DURATION \
diff --git a/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp b/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp
index c90545f17df21..370610bb02aa3 100644
--- a/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp
+++ b/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp
@@ -1140,6 +1140,7 @@ exec::AggregateRegistrationResult registerMinMaxBy(
                            .argumentType("C")
                            .build());
   const std::vector<std::string> supportedCompareTypes = {
+      "boolean",
       "tinyint",
       "smallint",
       "integer",
diff --git a/velox/functions/prestosql/aggregates/SumAggregate.cpp b/velox/functions/prestosql/aggregates/SumAggregate.cpp
index e905f59871c12..264ce57cfc249 100644
--- a/velox/functions/prestosql/aggregates/SumAggregate.cpp
+++ b/velox/functions/prestosql/aggregates/SumAggregate.cpp
@@ -48,7 +48,7 @@ exec::AggregateRegistrationResult registerSum(
           .build(),
   };
 
-  for (const auto& inputType : {"tinyint", "smallint", "integer", "bigint"}) {
+  for (const auto& inputType : {"smallint", "integer", "bigint"}) {
     signatures.push_back(exec::AggregateFunctionSignatureBuilder()
                              .returnType("bigint")
                              .intermediateType("bigint")