feat(member): 관리페이지 Aside TOC Panel 추가
#248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6541697 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gwansikk
requested changes
Sep 25, 2024
| @@ -29,7 +29,9 @@ const Header = ({ children, title, description }: SectionHeaderProps) => { | |||
| return ( | |||
| <div className="flex items-center justify-between"> | |||
| <div> | |||
| <h2 className="text-xl font-bold text-black">{title}</h2> | |||
| <h2 id={encodeURI(title)} className="text-xl font-bold text-black"> | |||
There was a problem hiding this comment.
섹션의 ID가 겹칠 수 있는 유스 케이스가 있다고 생각해요, 동일한 ID가 있을 경우 어떻게 되나요?
There was a problem hiding this comment.
해당 ID를 조금 더 구체화 하는 방법을 사용하겠습니다. useId 훅을 사용하면 될 것 같네요
|
|
||
| return ( | ||
| <> | ||
| {location.pathname === '/manage' && ( |
There was a problem hiding this comment.
Suggested change
| {location.pathname === '/manage' && ( | |
| {location.pathname === PATH.MANAGE && ( |
apps/member/src/components/panels/ShortcutPanel/ShortcutPanel.tsx
Outdated
Show resolved
Hide resolved
gwansikk
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tasks
scroll padding을 적용했습니다. 이는 현재 바로가기로 이동 시nav의 세로 크기 만큼 영역이 가려지기 때문입니다.scroll-behavior를smooth로 적용했습니다.Section.Header의h2컴포넌트에id값을 부여했습니다. (바로가기 이동을 위함)/manage경로에서만 표시됩니다.ETC
Section.Header의h2를 감지하고 이를 반영합니다. 따라서 관리페이지에서 TOC에 항목을 추가하고싶으시다면Section.Header를 사용하시면 됩니다.Screenshot