Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: be able to change feather's app icon when using certificate with different App ID #131

Open
castdrian opened this issue Oct 16, 2024 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@castdrian
Copy link

castdrian commented Oct 16, 2024

This is a general thing that happens when an app is signed with a cert that uses a different app id for provisioning(which also affects feather when signed as such) the call to setAlternateAppicon just returns OSError -52, there might be a way to do some objc hooking to get around this but I'm not sure, figured I'd raise this anyway, close if you don't think it's worth looking at

@khcrysalis khcrysalis added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 16, 2024
@castdrian
Copy link
Author

castdrian commented Oct 23, 2024

as a followup on this, fairly confident that keychain patches similar to https://github.com/dayanch96/YTLite/blob/main/Sideloading.x should do the trick, however not super duper sure which parts specifically cause this

@khcrysalis
Copy link
Owner

khcrysalis commented Oct 27, 2024

Would you know a way to do have something similar for missing network entitlements in certificates? this is useful information yes but app icon isn't really a priority

though I would like the local installation to work without entitlements but it seems unlikely

@castdrian
Copy link
Author

I don't believe circumventing that is possible without some type of elevated access ie TS/JB, these app dir, keychain and app icon thingies are more of a 'side effect' of using different app ids with those bundle ids so you can do some logos hooking, but I'm not really qualified to speak on the proper permission stuff, there's definitely smarter people than me out there

@castdrian castdrian changed the title chore: be able to change feather's app icon when using wildcard cert chore: be able to change feather's app icon when using certificate with different App ID Nov 15, 2024
@castdrian
Copy link
Author

Okay I've figured out a pretty lame way to fix these issues, it all works fine if you use the app id tied to the provisioning profile (without the team id) as bundle identifier. I've tried to hook into the stuff that uses bundle ids and return the id from the embedded provisioning file (can be seen here) but unfortunately it seems this is most likely some OS level issue that is breaking functionality when the app id and bundle id don't match 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants