Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve storing of knockoffs from spec2vec model #2

Open
kiaashour opened this issue Oct 3, 2020 · 0 comments
Open

Improve storing of knockoffs from spec2vec model #2

kiaashour opened this issue Oct 3, 2020 · 0 comments
Assignees
@kiaashour
Labels
enhancement New feature or request

Comments

@kiaashour
Copy link
Owner

Knockoffs from the embedding space of the spec2vec models are currently stored as numpy arrays, where as spectra/decoy spectra are stored either as SpectrumDocuments or Spectrum objects in the rest of the notebook. As a result, some functions have been changed to accommodate this difference.

Can looking at storing the knockoffs as SpectrumDocuments or creating a new class for that that inherits SpectrumDocuments.
@kiaashour kiaashour added the enhancement New feature or request label Oct 3, 2020
@kiaashour kiaashour self-assigned this Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiaashour kiaashour

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kiaashour