Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spaces not supported in layout name #224

Open
sellout opened this issue Nov 2, 2023 · 0 comments
Open

spaces not supported in layout name #224

sellout opened this issue Nov 2, 2023 · 0 comments

Comments

@sellout
Copy link

sellout commented Nov 2, 2023

Loading this layout in Kiibohd Configurator 1.1.0 results in errors in the build log:

FATAL Could not find 'MDErgo1-Atreus.kll' DefaultMap
FATAL Could not find 'default-0.kll' DefaultMap
FATAL Could not find 'MDErgo1-Atreus.kll' PartialMap
FATAL Could not find 'default-1.kll' PartialMap
FATAL Could not find 'MDErgo1-Atreus.kll' PartialMap
FATAL Could not find 'default-2.kll' PartialMap

and a number of others, but the log continues with a bunch of output until

[1/41] Generating KLL Layout
FAILED: generatedKeymap.h kll_defs.h usb_hid.h generatedPixelmap.c kll.json 
cd /controller && cmake -E env GITHUB_APIKEY=376423eb012a4587857428bf0bf10ac37415cb99 python3 -m kll --kiibohd-debug --config /controller/Scan/Devices/ISSILed/capabilities.kll /controller/Scan/Devices/MatrixARMPeriodic/capabilities.kll /controller/Scan/Devices/STLcd/capabilities.kll /controller/Scan/Devices/UARTConnect/capabilities.kll /controller/Macro/PartialMap/capabilities.kll /controller/Macro/PixelMap/capabilities.kll /controller/Output/HID-IO/capabilities.kll /controller/Output/USB/capabilities.kll /controller/Debug/latency/capabilities.kll /controller/Debug/led/capabilities.kll /controller/Lib/arm_cortex.kll /controller/Lib/kinetis.kll --base /controller/Scan/Infinity_Ergodox/scancode_map.kll /controller/Scan/Infinity_Ergodox/rightHand.kll /controller/Scan/Infinity_Ergodox/slave1.kll /controller/Scan/Infinity_Ergodox/leftHand.kll --default /root/.local/share/virtualenvs/Keyboards-41-guJFC/lib/python3.7/site-packages/kll/layouts/infinity_ergodox/lcdFuncMap.kll --partial --partial --emitter kiibohd --def-output /tmp/tmp.zXcP7o16yB/right/kll_defs.h --map-output /tmp/tmp.zXcP7o16yB/right/generatedKeymap.h --hid-output /tmp/tmp.zXcP7o16yB/right/usb_hid.h --pixel-output /tmp/tmp.zXcP7o16yB/right/generatedPixelmap.c --json-output /tmp/tmp.zXcP7o16yB/right/kll.json
Usage: kll [options..] [<generic>..]
__main__.py: error: argument --partial: expected at least one argument
ninja: build stopped: subcommand failed.
Error in build. Exiting...

which is even less clear than the earlier error messages.

There should at least be a clearer error when a layout has spaces in the name. But either s/ /_/g or (even better) allowing spaces and quoting paths would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant