-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKCE #58
Comments
The draft OAuth 2.1 spec requires the use of PKCE:
https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-1-12#section-4.1.1 |
@kilork Would it be okay if I work on a PR? |
@teohhanhui It is open source, we always expect contributions, you are welcome. Having some implementation is better than no implementation, after this we can decide on details, how to better fit into project, to not break already existing user base. |
I'd like to add support for PKCE, specifically:
code_challenge
toauth_url
.code_verifier
torequest_token
.(1) is not a strictly necessary change, as we can just add
code_challenge
andcode_challenge_method
to theUrl
returned fromauth_url
.(2) is however a required change, as I don't see an existing way to append
code_verifier
to the request body sent inrequest_token
.https://datatracker.ietf.org/doc/html/rfc7636
The text was updated successfully, but these errors were encountered: