Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL rendering #427

Closed
jnvsor opened this issue Sep 29, 2024 · 3 comments
Closed

RTL rendering #427

jnvsor opened this issue Sep 29, 2024 · 3 comments
Labels
Milestone

Comments

@jnvsor
Copy link
Member

jnvsor commented Sep 29, 2024

From @DRSDavidSoft in #422

Fix RTL issue: Kint isn't supposed to render in the RTL (Right-to-left) mode. If the direction of page (or the parent element) is set to RTL, then Kint wouldn't display properly. I believe it would be better to force direction: ltr into the Kint themes.

@jnvsor jnvsor added the bug label Sep 29, 2024
@jnvsor jnvsor added this to the 6 milestone Sep 29, 2024
@jnvsor
Copy link
Member Author

jnvsor commented Sep 29, 2024

@DRSDavidSoft Does d6350e1 fix the RTL issue? While the dump now looks fine on an RTL page I'm not sure how it'll affect RTL text inside dumps

@DRSDavidSoft
Copy link
Contributor

This sure does fix the Kint rendering. You are right about RTL text inside the dumps, but I believe this is expected behavior among devs who work with RTL content; If the content needs alternative direction, you need to apply it outside the dumping utility.

Alternative approach would be to use JS to apply the parent element's direction to it, or provide some manual override function... These don't really make sense for a dumper utility when there is a custom theming function available; I believe it's up to the user to provide their own CSS to deal with RTL text inside Kint. To me, the correct rendering of the Kint's rich renderer is far more important.

I suggest merging this PR as is, and maybe adding a note regarding RTL use in the docs. Please tell me which would suit Kint best, I'll help with that solution.

Also thanks for the quick addition of this to the scss! 😄 👍🏻

Lack of this was truly a pain point when trying to debug RTL apps, I always needed to apply this manually to the stylesheet of the application.

@jnvsor
Copy link
Member Author

jnvsor commented Sep 30, 2024

You are right about RTL text inside the dumps, but I believe this is expected behavior among devs who work with RTL content

Alright, then that's what we'll use, thanks for feedback

@jnvsor jnvsor closed this as completed in d6350e1 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants